Introduce build qualifier parameter #35155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpar-t
added
>non-issue
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
- VersionProperties.elasticsearch is now a string which can have qualifier and snapshot too - The Version class in the build no longer cares about snapshot and qualifier.
alpar-t
force-pushed
the
version-qualifier-param
branch
from
3ebcdda to
9dfd025
Compare
Contributor
Author
|
Thanks for the review @nik9000 |
alpar-t
added a commit
that referenced
this pull request
Nov 2, 2018
* Introduce property to set version qualifier - VersionProperties.elasticsearch is now a string which can have qualifier and snapshot too - The Version class in the build no longer cares about snapshot and qualifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work that begin in #34050
With this change we drop the snapshot and qualifier from the Version class of the build so this is represented as the version in
serverand we change the version properties to a string that can have qualifier and snapshot to be used throughout the build, this is also the version that is included in the build-tool properties.The final change will be to remove qualifier from
server's Version class.