SQL: Register missing processors #35121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add registration (and tests) for missing processors in the serialization chain. Fix elastic#35119
Collaborator
|
Pinging @elastic/es-search-aggs |
matriv
reviewed
Oct 31, 2018
x-pack/plugin/sql/src/test/java/org/elasticsearch/xpack/sql/expression/ProcessorTests.java
Outdated
Show resolved
Hide resolved
matriv
approved these changes
Oct 31, 2018
Contributor
matriv
left a comment
matriv
left a comment
There was a problem hiding this comment.
LGTM! just a typo in assertion msg
astefan
approved these changes
Oct 31, 2018
| try { | ||
| value = name.get(proc).toString(); | ||
| } catch (Exception ex) { | ||
| fail(procName + " does NOT provide a String NAME field\n" + ex); |
Contributor
There was a problem hiding this comment.
I am not exactly sure what you are doing here. The toString() will always give you a String... and get(proc) can throw an IllegalAccessException if the field is inaccessible (static, since proc.getField will check the public part). So why the "does not provide a String NAME field"? Sorry if I missed something.
Member
Author
There was a problem hiding this comment.
toString() is a shortcut for casting which also checks the value; it fails if the value is null.
The check is really for checking the field is static - I've updated the message as it was misleading.
costin
added a commit
that referenced
this pull request
Oct 31, 2018
costin
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add registration (and tests) for missing processors in the serialization
chain.
Fix #35119