Skip to content

update ILM integ test cluster poll interval to 1s #35113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 1, 2018
Merged

update ILM integ test cluster poll interval to 1s #35113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a3dae6
update IT poll interval to 1s
talevy Oct 31, 2018
d67c3e8
add logging
talevy Oct 31, 2018
2278a16
re-order check since original index is gone before shrunken
talevy Oct 31, 2018
a89d37d
Merge remote-tracking branch 'upstream/index-lifecycle' into ilm-test…
talevy Oct 31, 2018
30df5e5
remove logging
talevy Oct 31, 2018
7621571
Merge remote-tracking branch 'upstream/index-lifecycle' into ilm-test…
talevy Oct 31, 2018
638c273
add docs to the asserts
talevy Oct 31, 2018
1621e28
add more context to ordering of asserts
talevy Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugin/ilm/qa/multi-node/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ integTestCluster {
setting 'xpack.monitoring.enabled', 'false'
setting 'xpack.ml.enabled', 'false'
setting 'xpack.license.self_generated.type', 'trial'
setting 'indices.lifecycle.poll_interval', '2500ms'
setting 'indices.lifecycle.poll_interval', '1000ms'

}
24 changes: 22 additions & 2 deletions ...de/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,19 @@ public void testFullPolicy() throws Exception {
updatePolicy(originalIndex, policy);
// index document {"foo": "bar"} to trigger rollover
index(client(), originalIndex, "_id", "foo", "bar");

/*
* These asserts are in the order that they should be satisfied in, in
* order to maximize the time for all operations to complete.
* An "out of order" assert here may result in this test occasionally
* timing out and failing inappropriately.
*/
// asserts that rollover was called
assertBusy(() -> assertTrue(indexExists(secondIndex)));
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
// asserts that shrink deleted the original index
assertBusy(() -> assertFalse(indexExists(originalIndex)));
// asserts that the delete phase completed for the managed shrunken index
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
Copy link
Contributor

@gwbrown gwbrown Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the order of these asserts is important in a non-obvious way, we should probably include a comment explaining why.

}

public void testMoveToAllocateStep() throws Exception {
Expand Down Expand Up @@ -150,9 +160,19 @@ public void testMoveToRolloverStep() throws Exception {
" }\n" +
"}");
client().performRequest(moveToStepRequest);

/*
* These asserts are in the order that they should be satisfied in, in
* order to maximize the time for all operations to complete.
* An "out of order" assert here may result in this test occasionally
* timing out and failing inappropriately.
*/
// asserts that rollover was called
assertBusy(() -> assertTrue(indexExists(secondIndex)));
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
// asserts that shrink deleted the original index
assertBusy(() -> assertFalse(indexExists(originalIndex)));
// asserts that the delete phase completed for the managed shrunken index
assertBusy(() -> assertFalse(indexExists(shrunkenOriginalIndex)));
Copy link
Contributor

@gwbrown gwbrown Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the order of these asserts is important in a non-obvious way, we should probably include a comment explaining why.

}

public void testRolloverAction() throws Exception {
Expand Down