SQL: Fix NPE thrown if HAVING filter evals to null #35108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surround script with `nullSafeFilter` also for `AggFilter` translation. Fixed query translation tests to properly set `onAggs`. Fixes: elastic#35107
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
approved these changes
Oct 31, 2018
matriv
pushed a commit
that referenced
this pull request
Oct 31, 2018
Surround script with `nullSafeFilter` also for `AggFilter` translation. Fixed query translation tests to properly set `onAggs`. Fixes: #35107
Contributor
Author
|
Backported to |
matriv
pushed a commit
that referenced
this pull request
Oct 31, 2018
Surround script with `nullSafeFilter` also for `AggFilter` translation. Fixed query translation tests to properly set `onAggs`. Fixes: #35107
Contributor
Author
|
Backported to |
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Oct 31, 2018
Include `null` literals when generating the painless script for `IN` expressions. Previously, they were skipped, because of an issue that had been fixed with elastic#35108. Fixes: elastic#35122
matriv
pushed a commit
that referenced
this pull request
Nov 2, 2018
matriv
pushed a commit
that referenced
this pull request
Nov 2, 2018
matriv
pushed a commit
that referenced
this pull request
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surround script with
nullSafeFilteralso forAggFiltertranslation.Fixed query translation tests to properly set
onAggs.Fixes: #35107