Skip to content

Conversation

@ramudu63
Copy link

change some mistake in align

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

change some mistake in align
@ramudu63
Copy link
Author

change some mistake in align

@nik9000 nik9000 changed the title change some mistake in align Docs: change some mistake in align Oct 30, 2018
@nik9000 nik9000 added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Oct 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

The change looks good to me @ramudu63. Could you sign our CLA? We need it for every change, if one as small as flipping a square bracket.

@colings86
Copy link
Contributor

I don't think we should merge this change as is, since the existing text is trying to convey that the value of the random score is between 0 and 1, inclusive on the lower bound and exclusive on the upper bound. So this is not a typo but in fact an intentional notation. We can discuss the merits of using this notation but I think if we want to get rid of the notation for clarity we need to add an explicit description in words instead since [0,1] is not correct for the behaviour a user will see (because the upper bound is exclusive)

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

I've never seen someone use [0, 1[ for exclusive upper bound. I've seen [0, 1) for that. But I agree we should avoid the interval syntax because we get questions about it from time to time.

@colings86
Copy link
Contributor

AFAIK both notations are accepted though I'll admit I have seen [0,1) more often.

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Oct 30, 2018
The `random_score` function produces values between 0 (inclusive) and 1
(exclusive) and documented it with fancy methematical range notation. It
is so fancy I thought it was a typo. This changes the documentation to
use words.

Relates to elastic#35084
@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

Hey @ramudu63, @colings86 and I talked this through and went with #35093 instead. Thanks for submitting this!

@nik9000 nik9000 closed this Oct 30, 2018
nik9000 added a commit that referenced this pull request Oct 30, 2018
The `random_score` function produces values between 0 (inclusive) and 1
(exclusive) and documented it with fancy methematical range notation. It
is so fancy I thought it was a typo. This changes the documentation to
use words.

Relates to #35084
nik9000 added a commit that referenced this pull request Oct 30, 2018
The `random_score` function produces values between 0 (inclusive) and 1
(exclusive) and documented it with fancy methematical range notation. It
is so fancy I thought it was a typo. This changes the documentation to
use words.

Relates to #35084
nik9000 added a commit that referenced this pull request Oct 30, 2018
The `random_score` function produces values between 0 (inclusive) and 1
(exclusive) and documented it with fancy methematical range notation. It
is so fancy I thought it was a typo. This changes the documentation to
use words.

Relates to #35084
nik9000 added a commit that referenced this pull request Oct 30, 2018
The `random_score` function produces values between 0 (inclusive) and 1
(exclusive) and documented it with fancy methematical range notation. It
is so fancy I thought it was a typo. This changes the documentation to
use words.

Relates to #35084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants