Skip to content

Conversation

@talevy
Copy link
Contributor

@talevy talevy commented Oct 29, 2018

This PR renames the CRUD APIS for ILM

GET _ilm/, _ilm -> _ilm/policy/, _ilm/policy
PUT _ilm/ -> _ilm/policy/
DELETE _ilm/ -> _ilm/policy/

closes #34929.

@talevy talevy added >non-issue >refactoring :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 29, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dakrone
Copy link
Member

dakrone commented Oct 29, 2018

I feel like this is missing the documentation changes also? Shouldn't we have some docs somewhere referencing this that need to change?

@talevy
Copy link
Contributor Author

talevy commented Oct 29, 2018

indeed @dakrone, I forgot to test the docs :(. pushed the doc changes up now!

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy
Copy link
Contributor Author

talevy commented Oct 29, 2018

test this please

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 5141084 into elastic:index-lifecycle Oct 30, 2018
@talevy talevy deleted the ilm-policy branch October 30, 2018 23:19
talevy added a commit that referenced this pull request Oct 30, 2018
This PR renames the CRUD APIS for ILM

GET _ilm/<policy>, _ilm -> _ilm/policy/<policy>, _ilm/policy
PUT _ilm/<policy> -> _ilm/policy/<policy>
DELETE _ilm/<policy> -> _ilm/policy/<policy>

closes #34929.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue >refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants