[ML] Refactor doc value format into ExtractedField #35053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the knowledge of which doc value format to be used down to the `ExtractedField` instead of being in the data extractor.
Collaborator
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Oct 29, 2018
dimitris-athanasiou
deleted the
move-doc-value-format-into-extracted-field
branch
dimitris-athanasiou
added a commit
that referenced
this pull request
Oct 29, 2018
This commit moves the knowledge of which doc value format to be used down to the `ExtractedField` instead of being in the data extractor.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit moves the knowledge of which doc value format to be used down to the `ExtractedField` instead of being in the data extractor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the knowledge of which doc value format
to be used down to the
ExtractedFieldinstead of beingin the data extractor.