Add warning about upcoming expanded fields limit #34906
Conversation
Starting with Elasticsearch 7.0, we limit the number of automatically expanded
fields for the "all fields" mode ("default_field": "*") for the query_string and
simple_query_string queries to 1024 fields (see elastic#26541). This change adds a
deprecation warning to the QueryParserHelper where in the next major version we
will throw an error to warn users of the upcoming change.
Relates to elastic#26541
cbuescher
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search-aggs |
|
@jimczi this is meant as the follow up to yesterdays docs change (#34801). I think we also need some not in the migration docs, but as far as I understand I would need to add the note about the limit coming into effect on master, right? If so, I will do that in another PR, if I should add this to some 6.x migration doc please let me know in this PR. I always get confused where these notes should go. |
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
You can add a deprecation note in https://github.com/elastic/elasticsearch/blob/6.x/docs/reference/migration/migrate_6_0/search.asciidoc
Isn't that document intended for migrations to 6.0? My understanding so far was that we add breaking changes in the versions that they should be adressed. That would be 7.0 for the limit introduced here, at least for the breaking change. https://github.com/elastic/elasticsearch/tree/6.x/docs/reference/migration/migrate_7_0 looks quite empty though, so I guess somewhere in https://github.com/elastic/elasticsearch/tree/master/docs/reference/migration/migrate_7_0 would be the right spot? |
|
I added deprecation notes in a new |
| ==== `query_string` and `simple_query_string` query | ||
|
|
||
| Using automatically expanded fields for the "all fields" mode ("default_field": "*") | ||
| for the `query_string` and `simple_query_string` now raises a warning and a deprecation |
There was a problem hiding this comment.
it is also applied to multi_match queries.
3 participants
Starting with Elasticsearch 7.0, we limit the number of automatically expanded
fields for the "all fields" mode ("default_field": "*") for the query_string and
simple_query_string queries to 1024 fields (see #26541). This change adds a
deprecation warning to the QueryParserHelper where in the next major version we
will throw an error to warn users of the upcoming change.
Relates to #26541