Always enforce cluster-wide shard limit #34892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the option to run a cluster without enforcing the cluster-wide shard limit, making strict enforcement the default and only behavior. The limit can still be adjusted as desired using the cluster settings API.
gwbrown
added
>enhancement
>breaking
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
approved these changes
Nov 22, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I am so sorry @gwbrown for the delay in reviewing. This is looking really great! I left a few incredibly minor nits. No need for another round.
| Elasticsearch 7.0, as strict enforcement of the limit will be the default and | ||
| only behavior. | ||
| There is a soft limit on the number of shards in a cluster, based on the number | ||
| of nodes in the cluster. This is intended to prevent operations which may |
Member
There was a problem hiding this comment.
Nit: a single space is fine; the CSS/HTML ensures consistent style anyway.
|
|
||
| dataNodes = ensureMultipleDataNodes(dataNodes); | ||
|
|
||
| int firstShardCount = between(2,10); |
| int firstIndexShards = firstIndexFactor * dataNodes; | ||
| int firstIndexReplicas = 0; | ||
|
|
||
| int secondIndexFactor = between(1,3); |
| } | ||
|
|
||
| static List<Function<ClusterState, DeprecationIssue>> CLUSTER_SETTINGS_CHECKS = | ||
| Collections.unmodifiableList(Arrays.asList( |
Member
There was a problem hiding this comment.
Collections.emptyList is unmodifiable too?
Contributor
Author
|
Thanks for the review @jasontedor! |
Contributor
Author
|
The failure does not reproduce locally and appears to be unrelated. @elasticmachine run the gradle build tests 2 please |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the option to run a cluster without enforcing the
cluster-wide shard limit, making strict enforcement the default and only
behavior. The limit can still be adjusted as desired using the cluster
settings API.
This is a follow-up to #34021
Closes #20705