Remove nio transport from 6.x (#34756) #34879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the nio transport work from 6.x This work will never be enabled outside of the test framework. Additionally, we get sufficient testing on master/7.0 right now. So there is no need to have it on 6.x. This is motivated by the fact that this work has diverged significantly from master. This makes backports difficult. Additionally, the nio transport uses many connections increasing the timeouts due to resource exhaustion in the build.
Tim-Brooks
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
This is just a backport. |
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Oct 26, 2018
This commit removes the nio transport work from 6.x This work will never be enabled outside of the test framework. Additionally, we get sufficient testing on master/7.0 right now. So there is no need to have it on 6.x. This is motivated by the fact that this work has diverged significantly from master. This makes backports difficult. Additionally, the nio transport uses many connections increasing the timeouts due to resource exhaustion in the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the nio transport work from 6.x This work will never
be enabled outside of the test framework. Additionally, we get
sufficient testing on master/7.0 right now. So there is no need to have
it on 6.x.
This is motivated by the fact that this work has diverged significantly
from master. This makes backports difficult. Additionally, the nio
transport uses many connections increasing the timeouts due to resource
exhaustion in the build.