Drop deprecationLogger from AbstractComponent #34859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops the `deprecationLogger` from `AbstractComponent`, moving it to places where we need it. This saves us from building a bunch of `DeprecationLogger`s that we don't need. Relates to elastic#34488
nik9000
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra |
jaymode
approved these changes
Oct 25, 2018
Member
jaymode
left a comment
jaymode
left a comment
There was a problem hiding this comment.
I left a nit about casing. LGTM
| * </dl> | ||
| */ | ||
| class S3Repository extends BlobStoreRepository { | ||
| private static final Logger logger = LogManager.getLogger(S3Repository.class); |
Member
There was a problem hiding this comment.
this is a nit but typically static finals should be all uppercase (LOGGER and DEPRECATION_LOGGER)
Member
Author
There was a problem hiding this comment.
I tend to stick to the google style for things like this. These things aren't constants so I use the normal case.
Member
There was a problem hiding this comment.
It would be great to have a standard across the team for this; I've been asked to use all uppercase before so I adopted it, but I get the point of the google style too. Anyway, this shouldn't block your change
nik9000
added a commit
that referenced
this pull request
Oct 27, 2018
Drops the `deprecationLogger` from `AbstractComponent`, moving it to places where we need it. This saves us from building a bunch of `DeprecationLogger`s that we don't need. Relates to #34488
Member
Author
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Drops the `deprecationLogger` from `AbstractComponent`, moving it to places where we need it. This saves us from building a bunch of `DeprecationLogger`s that we don't need. Relates to #34488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the
deprecationLoggerfromAbstractComponent, moving it toplaces where we need it. This saves us from building a bunch of
DeprecationLoggers that we don't need.Relates to #34488