HLRC: Add security Create Token API #34791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the Create Token API (POST /_xpack/security/oauth2/token) to the High Level Rest Client.
tvernum
added
>enhancement
v7.0.0
:Core/Java High Level REST Client
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security |
Collaborator
|
Pinging @elastic/es-core-infra |
jaymode
reviewed
Oct 24, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java
Outdated
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/SecurityClient.java
Outdated
Show resolved
Hide resolved
...high-level/src/test/java/org/elasticsearch/client/documentation/SecurityDocumentationIT.java
Outdated
Show resolved
Hide resolved
jaymode
approved these changes
Oct 25, 2018
client/rest-high-level/src/main/java/org/elasticsearch/client/security/CreateTokenRequest.java
Outdated
Show resolved
Hide resolved
bizybot
approved these changes
Oct 26, 2018
Contributor
bizybot
left a comment
bizybot
left a comment
There was a problem hiding this comment.
LGTM other than a comment for checks. Thank you.
client/rest-high-level/src/main/java/org/elasticsearch/client/security/CreateTokenRequest.java
Show resolved
Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/security/CreateTokenRequest.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine test this please |
98 tasks
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This adds the Create Token API (POST /_xpack/security/oauth2/token) to the High Level Rest Client. Relates: #29827
tvernum
added a commit
that referenced
this pull request
Oct 30, 2018
This adds the Create Token API (POST /_xpack/security/oauth2/token) to the High Level Rest Client. Relates: #29827
jpountz
removed
the
:Security/Authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Create Token API (POST /_xpack/security/oauth2/token)
to the High Level Rest Client.