Skip to content

Conversation

@alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Oct 23, 2018

The contains syntax was added in #30874 but the skips were not properly
put in place.
The java runner has the feature so the tests will run as part of the
build, but language clients will be able to support it at their own
pace.

The contains syntax was added in elastic#30874 but the skips were not properly
put in place.
The java runner has the feature so the tests will run as part of the
build, but language clients will be able to support it at their own
pace.
@alpar-t alpar-t added >non-issue :Delivery/Build Build or test infrastructure v7.0.0 labels Oct 23, 2018
@alpar-t alpar-t requested review from javanna and tvernum October 23, 2018 10:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 23, 2018

I used the following commands to make sure I get them all:

find -name *.yml -print0 | xargs -0 grep 'contains:' -  |  sort
find -name *.yml -print0 | xargs -0 grep 'contains:' -l | xargs grep 'features: contains' -l  |  sort

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM should we also enforce that tests which contain a contains assertion also need to have the skip for feature contains?

This has not been caught by clients as none of the affected tests is run by them, but supporting such assertion make it possible for us to use it anywhere so it is still a good idea to require the skip section.

#
"Matrix stats aggs loaded":
- skip:
reason: "contains is a newly added assertion"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the reason can be skipped when you specify a feature. it is required only when specifying versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atorok ping not sure you have seen this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @javanna I did not interpret that as something you would like me to change.
The reason is overly repetitive even if used with version, but it does seem to add some more context with someone not as familiar with this syntax. That's why I left it in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a big deal, just that I think skip features contains is already self-explaining and adding a reason does not add value, but I am fine with keeping it. I did not mean that I wanted you to change it, I was ok with you replying that you are leaving it as-is, just so I know you've seen the comment ;)

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpar-t alpar-t merged commit 5953696 into elastic:master Oct 25, 2018
@alpar-t alpar-t deleted the add-skip-yml branch October 25, 2018 05:51
@alpar-t
Copy link
Contributor Author

alpar-t commented Oct 25, 2018

Thanks for the reviews. @javanna I'll implement your recommendations in a separate PR.

kcm pushed a commit that referenced this pull request Oct 30, 2018
The contains syntax was added in #30874 but the skips were not properly
put in place.
The java runner has the feature so the tests will run as part of the
build, but language clients will be able to support it at their own
pace.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants