Scripting: Remove SearchScript #34730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commite removes the last non context based script class.
rjernst
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra |
This was accidentally left over when converting to FieldScript. closes elastic#34683
jdconrad
approved these changes
Oct 23, 2018
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
@rjernst This is awesome! Left one comment and adding one request - the change of contexts here puts the Painless docs out of date. Doesn't have to be this PR, but would you please update the context docs to reflect the changes at some point before 7.0?
| Compiler compiler = contextsToCompilers.get(context); | ||
|
|
||
| if (context.instanceClazz.equals(SearchScript.class)) { | ||
| Constructor<?> constructor = compile(compiler, scriptName, scriptSource, params); |
Contributor
There was a problem hiding this comment.
There are two versions of the compile method. Now that the two special cases are gone for search/executable script contexts, would you please check to see if this version can be removed completely? It's possible some tests still use it, though.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit removes the last non context based script class.
jdconrad
added a commit
that referenced
this pull request
Nov 7, 2018
With the removal of SearchScript (#34730), an extraneous compile method was left behind in PainlessScriptEngine. This change removes the method and updates the tests that depend on it to use the main compile method which gives better test coverage.
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Nov 13, 2018
With the removal of SearchScript (elastic#34730), an extraneous compile method was left behind in PainlessScriptEngine. This change removes the method and updates the tests that depend on it to use the main compile method which gives better test coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the last non context based script class.