Skip to content

Remove unused methods in ValueType #34624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Remove unused methods in ValueType #34624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions server/src/main/java/org/elasticsearch/search/aggregations/support/ValueType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ public boolean isNumeric() {
}
},
GEOPOINT((byte) 8, "geo_point", "geo_point", ValuesSourceType.GEOPOINT, IndexGeoPointFieldData.class, DocValueFormat.GEOHASH) {
@Override
public boolean isGeoPoint() {
return true;
}
},
BOOLEAN((byte) 9, "boolean", "boolean", ValuesSourceType.NUMERIC, IndexNumericFieldData.class, DocValueFormat.BOOLEAN) {
@Override
Expand Down Expand Up @@ -108,10 +104,6 @@ public boolean isNumeric() {
this.defaultFormat = defaultFormat;
}

public String description() {
return description;
}

public String getPreferredName() {
return preferredName;
}
Expand All @@ -120,10 +112,6 @@ public ValuesSourceType getValuesSourceType() {
return valuesSourceType;
}

public boolean compatibleWith(IndexFieldData fieldData) {
return fieldDataType.isInstance(fieldData);
}

public boolean isA(ValueType valueType) {
return valueType.valuesSourceType == valuesSourceType &&
valueType.fieldDataType.isAssignableFrom(fieldDataType);
Expand All @@ -145,10 +133,6 @@ public boolean isFloatingPoint() {
return false;
}

public boolean isGeoPoint() {
return false;
}

public static ValueType resolveForScript(String type) {
switch (type) {
case "string": return STRING;
Expand Down