-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Separate remote clusters docs from CCS #34612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With remote clusters taking on a larger role, we have make the infrastructure more generic than being tied to cross-cluster search (CCS). We want to refer to the remote clusters configuration in the cross-cluster replication (CCR) docs. Yet, these docs are still tied to CCS. This commit extracts the remote clusters docs from CCS (with some wording changes to make them more general) so that we can refer to them in the CCR docs.
|
Pinging @elastic/es-search-aggs |
|
Pinging @elastic/es-distributed |
martijnvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| ifndef::include-xpack[] | ||
| This functionality is used in | ||
| <<modules-cross-cluster-search,cross-cluster search>>, and possibly other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be nice to move this up to the first paragraph if you can. Maybe not worded exactly like this, but similar. I'd also drop ", and possible other features." If we want to say that it might be used for more things in the future then we should say that. Otherwise I'd just leave that out entirely.
|
|
||
| If a remote cluster is configured via `elasticsearch.yml` only the nodes with | ||
| that configuration will be able to connect to the remote cluster. In other | ||
| words, functionality that relies on remote cluster requests will have to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a very particular feature. Almost like we'd be better off giving the advice to set the remote cluster up in every elasticsearch.yml.
| that configuration will be able to connect to the remote cluster. In other | ||
| words, functionality that relies on remote cluster requests will have to be | ||
| driven specifically from those nodes. Remote clusters set via the | ||
| <<cluster-update-settings,cluster settings API>> will be available on every node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence feels out of order with the one after it.
|
|
||
| ////////////////////////// | ||
|
|
||
| We want to be sure that settings have been updated, because we'll use them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this note is entirely accurate any more.
|
|
||
| ////////////////////////// | ||
|
|
||
| We want to be sure that settings have been updated, because we'll use them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this again.
s1monw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some suggestions LGTM no need for another review
| only to a limited number of nodes in the remote cluster. Each remote cluster is | ||
| referenced by a name and a list of seed nodes. When a remote cluster is | ||
| registered, its cluster state is retrieved from one of the seed nodes so that up | ||
| to 3 _gateway nodes_ are selected to be connected to as part of remote cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be preexisting but we should make clear that this is by default up to 3. it sounds like a max.
| <<remote-cluster-settings>>). | ||
|
|
||
| Each node in a cluster that has remote clusters configured connects to one or | ||
| more _gateway nodes_ and uses them to federate requests to the remote cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we rather say proxy than federate?
|
|
||
| `cluster.remote.connections_per_cluster`:: | ||
|
|
||
| The number of nodes to connect to per remote cluster. The default is `3`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also mention that they are gateway nodes?
With remote clusters taking on a larger role, we have make the infrastructure more generic than being tied to cross-cluster search (CCS). We want to refer to the remote clusters configuration in the cross-cluster replication (CCR) docs. Yet, these docs are still tied to CCS. This commit extracts the remote clusters docs from CCS (with some wording changes to make them more general) so that we can refer to them in the CCR docs.
With remote clusters taking on a larger role, we have make the infrastructure more generic than being tied to cross-cluster search (CCS). We want to refer to the remote clusters configuration in the cross-cluster replication (CCR) docs. Yet, these docs are still tied to CCS. This commit extracts the remote clusters docs from CCS (with some wording changes to make them more general) so that we can refer to them in the CCR docs.
With remote clusters taking on a larger role, we have make the infrastructure more generic than being tied to cross-cluster search (CCS). We want to refer to the remote clusters configuration in the cross-cluster replication (CCR) docs. Yet, these docs are still tied to CCS. This commit extracts the remote clusters docs from CCS (with some wording changes to make them more general) so that we can refer to them in the CCR docs.
Relates #33413