Skip to content

Conversation

@jasontedor
Copy link
Member

With remote clusters taking on a larger role, we have make the infrastructure more generic than being tied to cross-cluster search (CCS). We want to refer to the remote clusters configuration in the cross-cluster replication (CCR) docs. Yet, these docs are still tied to CCS. This commit extracts the remote clusters docs from CCS (with some wording changes to make them more general) so that we can refer to them in the CCR docs.

Relates #33413

With remote clusters taking on a larger role, we have make the
infrastructure more generic than being tied to cross-cluster search
(CCS). We want to refer to the remote clusters configuration in the
cross-cluster replication (CCR) docs. Yet, these docs are still tied to
CCS. This commit extracts the remote clusters docs from CCS (with some
wording changes to make them more general) so that we can refer to them
in the CCR docs.
@jasontedor jasontedor added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.5.0 labels Oct 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


ifndef::include-xpack[]
This functionality is used in
<<modules-cross-cluster-search,cross-cluster search>>, and possibly other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice to move this up to the first paragraph if you can. Maybe not worded exactly like this, but similar. I'd also drop ", and possible other features." If we want to say that it might be used for more things in the future then we should say that. Otherwise I'd just leave that out entirely.


If a remote cluster is configured via `elasticsearch.yml` only the nodes with
that configuration will be able to connect to the remote cluster. In other
words, functionality that relies on remote cluster requests will have to be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a very particular feature. Almost like we'd be better off giving the advice to set the remote cluster up in every elasticsearch.yml.

that configuration will be able to connect to the remote cluster. In other
words, functionality that relies on remote cluster requests will have to be
driven specifically from those nodes. Remote clusters set via the
<<cluster-update-settings,cluster settings API>> will be available on every node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence feels out of order with the one after it.


//////////////////////////

We want to be sure that settings have been updated, because we'll use them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this note is entirely accurate any more.


//////////////////////////

We want to be sure that settings have been updated, because we'll use them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this again.

Copy link
Contributor

@s1monw s1monw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions LGTM no need for another review

only to a limited number of nodes in the remote cluster. Each remote cluster is
referenced by a name and a list of seed nodes. When a remote cluster is
registered, its cluster state is retrieved from one of the seed nodes so that up
to 3 _gateway nodes_ are selected to be connected to as part of remote cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be preexisting but we should make clear that this is by default up to 3. it sounds like a max.

<<remote-cluster-settings>>).

Each node in a cluster that has remote clusters configured connects to one or
more _gateway nodes_ and uses them to federate requests to the remote cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rather say proxy than federate?


`cluster.remote.connections_per_cluster`::

The number of nodes to connect to per remote cluster. The default is `3`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also mention that they are gateway nodes?

@jasontedor jasontedor merged commit b2dc584 into elastic:master Oct 20, 2018
jasontedor added a commit that referenced this pull request Oct 20, 2018
With remote clusters taking on a larger role, we have make the
infrastructure more generic than being tied to cross-cluster search
(CCS). We want to refer to the remote clusters configuration in the
cross-cluster replication (CCR) docs. Yet, these docs are still tied to
CCS. This commit extracts the remote clusters docs from CCS (with some
wording changes to make them more general) so that we can refer to them
in the CCR docs.
@jasontedor jasontedor deleted the remote-clusters-docs branch October 20, 2018 12:44
kcm pushed a commit that referenced this pull request Oct 30, 2018
With remote clusters taking on a larger role, we have make the
infrastructure more generic than being tied to cross-cluster search
(CCS). We want to refer to the remote clusters configuration in the
cross-cluster replication (CCR) docs. Yet, these docs are still tied to
CCS. This commit extracts the remote clusters docs from CCS (with some
wording changes to make them more general) so that we can refer to them
in the CCR docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.5.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants