Remove hand-coded XContent duplicate checks #34588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we cleanup hand-coded duplicate checks in XContent parsing. They were necessary previously but since we reconfigured the underlying parser in elastic#22073 and elastic#22225, these checks are obsolete and were also ineffective unless an undocumented system property has been set. As we also remove this escape hatch, we can remove the additional checks as well. Closes elastic#22253
danielmitterdorfer
added
>enhancement
:Core/Infra/REST API
Collaborator
|
Pinging @elastic/es-core-infra |
Member
Author
|
Note to reviewers: I intentionally kept tests so we check that duplicates are indeed detected. |
Member
I don't think we need to do this. This effectively amounts to unit tests of Jackson now that we defer to its behavior. I think a single test that each of the XContent parsers reject duplicates is sufficient, but we don't need to go to the individual uses of XContent parsers to test for duplicates. |
Member
Author
Fine for me. Then I'll remove these tests soon. For reference, the test that covers this is |
Member
Author
|
@elasticmachine test this please |
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
With this commit we cleanup hand-coded duplicate checks in XContent parsing. They were necessary previously but since we reconfigured the underlying parser in #22073 and #22225, these checks are obsolete and were also ineffective unless an undocumented system property has been set. As we also remove this escape hatch, we can remove the additional checks as well. Closes #22253 Relates #34588
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Oct 8, 2020
The setting es.xcontent.strict_duplicate_detection was removed in 7.0 (see elastic#34588). It was an undocumented setting, but enough users relied on it that its absence is causing problems during upgrades. This commit adds a message to the deprecation log if this setting is present at startup.
williamrandolph
added a commit
that referenced
this pull request
Dec 18, 2020
#63500) * Add deprecation warning for removed setting The setting es.xcontent.strict_duplicate_detection was removed in 7.0 (see #34588). It was an undocumented setting, but enough users relied on it that its absence is causing problems during upgrades. This commit adds a message to the deprecation log if this setting is present at startup. * Spotless formatting * Avoid forbidden API * Reset between custom config tests * Spotless apply * Access system properties consistently * Revert changes to ConfigurationTests setup Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we cleanup hand-coded duplicate checks in XContent
parsing. They were necessary previously but since we reconfigured the
underlying parser in #22073 and #22225, these checks are obsolete and
were also ineffective unless an undocumented system property has been
set. As we also remove this escape hatch, we can remove the additional
checks as well.
Closes #22253