XPack/HLRC request/response compatibility tests #34547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 15, 2018 15:37
Collaborator
|
Pinging @elastic/es-core-infra |
Member
|
A while ago I started hacking together a thing in |
nik9000
reviewed
Oct 17, 2018
...esponse-tests/src/test/java/org/elasticsearch/protocol/xpack/license/LicenseStatusTests.java
Outdated
Show resolved
Hide resolved
added 3 commits
October 19, 2018 13:40
7 tasks
added 2 commits
October 19, 2018 16:02
…l_cleanup_2' into hlrc_xprotocol_response_tests
vladimirdolzhenko
changed the base branch from
hlrc_xprotocol_cleanup_1
to
hlrc_xprotocol_cleanup_2
nik9000
reviewed
Oct 25, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
I'm happy with this! Do you want to drop the WIP tag?
added 5 commits
October 26, 2018 08:21
vladimirdolzhenko
changed the base branch from
hlrc_xprotocol_cleanup_2
to
master
added 3 commits
October 29, 2018 16:18
…' into hlrc_xprotocol_response_tests
Contributor
Author
|
@nik9000 this PR at the latest stage as far as all preliminary PRs are merged, could you pls have another look into it ? |
nik9000
approved these changes
Oct 30, 2018
...in/core/src/test/java/org/elasticsearch/protocol/AbstractHlrcStreamableXContentTestCase.java
Outdated
Show resolved
Hide resolved
Member
|
Wonderful! |
added 2 commits
October 30, 2018 17:57
…col_response_tests
vladimirdolzhenko
added a commit
to vladimirdolzhenko/elasticsearch
that referenced
this pull request
Oct 31, 2018
Relates elastic#34451 , backports elastic#34547 (cherry picked from commit 28bb1a3)
vladimirdolzhenko
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually we don't have any validation for the compatibility of XPack requests/responses and HLRC implementation of those requests/responses.
This PR is to fill this gap
note: while we have
xpack/protocolthese tests could not be run due to jar hell.Relates to #34451