Add dedicated test for chain replication #34497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>non-issue
:Distributed Indexing/CCR
This commit adds a dedicated test that chain replication leader -> middle -> follow is successful.
jasontedor
force-pushed
the
chain-replication
branch
from
0209f44 to
a856aee
Compare
martijnvg
approved these changes
Oct 16, 2018
| } | ||
| } | ||
|
|
||
| private static void index(RestClient client, String index, String id, Object... fields) throws IOException { |
Member
There was a problem hiding this comment.
Should we in a follow up add a Gradle module inside the qa directory that contains these helper methods and let the qa modules depend on this module? We've been repeating these methods many times now.
Member
Author
There was a problem hiding this comment.
Yes, I thought the same thing! Can you take that on?
jasontedor
added a commit
that referenced
this pull request
Oct 16, 2018
This commit adds a dedicated test that chain replication leader -> middle -> follow is successful.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit adds a dedicated test that chain replication leader -> middle -> follow is successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a dedicated test that chain replication leader -> middle -> follow is successful.