Analysis: Wrap at 140 columns #34494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies our standard column width to all analysis plugins.
nik9000
added
>non-issue
:Search Relevance/Analysis
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
commented
Oct 15, 2018
| this.encoder = null; | ||
| this.maxcodelength = settings.getAsInt("max_code_len", 4); | ||
| } else if ("bm".equalsIgnoreCase(encodername) || "beider_morse".equalsIgnoreCase(encodername) || "beidermorse".equalsIgnoreCase(encodername)) { | ||
| } else if ("bm".equalsIgnoreCase(encodername) |
Member
Author
There was a problem hiding this comment.
There is a fair bit of camelCase left in this file which would be good to look at at some point but I don't think now is that time.
jimczi
approved these changes
Oct 15, 2018
| this.encoder = null; | ||
| this.maxcodelength = settings.getAsInt("max_code_len", 4); | ||
| } else if ("bm".equalsIgnoreCase(encodername) || "beider_morse".equalsIgnoreCase(encodername) || "beidermorse".equalsIgnoreCase(encodername)) { | ||
| } else if ("bm".equalsIgnoreCase(encodername) |
Member
Author
|
Thanks for reviewing @jimczi! |
nik9000
added a commit
that referenced
this pull request
Oct 17, 2018
Applies our standard column width to all analysis plugins.
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Applies our standard column width to all analysis plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies our standard column width to all analysis plugins.