Skip to content

Conversation

@lipsill
Copy link
Contributor

@lipsill lipsill commented Oct 11, 2018

Minor change displaying Testing as h1 instead of plain text.

Asciidoc anchorId cannot contain white spaces, hence the rendering till now has been [[Testing Framework Cheatsheet]] = Testing as plain text. The change is defining TestingFrameworkCheatsheet as an anchor to the block (by simply removing the white spaces), thus = Testing can be correctly parsed as h1.
The anchor is not used in a cross reference, so this change should not brake any references.

Display `Testing` as h1
@lipsill
Copy link
Contributor Author

lipsill commented Oct 11, 2018

@dakrone can you have a look at this if that is what you meant back in the day: define an anchor and a title? Thanks!

PS: TBH I find it quirky and cute as is ;)

@colings86 colings86 added >docs General docs changes :Delivery/Build Build or test infrastructure labels Oct 12, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t alpar-t merged commit 305b584 into elastic:master Oct 15, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 15, 2018
* elastic/master:
  Mute PartitionedRoutingIT#testShrinking on Windows
  Mute testToQuery test
  [TEST] Make sure there are shards started so that `ESIntegTestCase#assertSameDocIdsOnShards()` does not fail with shard not found.
  Change shard changes api's threadpool from get to search (elastic#34421)
  Update TESTING.asciidoc title (elastic#34401)
  Tests: Fix DateFormatter equals tests with locale (elastic#34435)
  Docs: Remove unnecessary qualifier from wildcard import note (elastic#34419)
  CCR/TEST: AwaitsFix testFailOverOnFollower
  [Painless] Add a Map for java names to classes for use in the custom classloader (elastic#34424)
  TEST: Fix indentation in FullClusterRestartIT (elastic#34420)
  [WIP] Ingest Attachement: Upgrade tika to v1.19.1 (elastic#33896)
  NETWORKING: Upgrade Netty to 4.1.30 (elastic#34417)
  Allow an AuthenticationResult to return metadata (elastic#34382)
  [ML] Add an ingest pipeline definition to structure finder (elastic#34350)
  Handle pre-6.x time fields (elastic#34373)
  ListenableFuture should preserve ThreadContext (elastic#34394)
@lipsill lipsill deleted the patch-2 branch October 24, 2018 11:25
kcm pushed a commit that referenced this pull request Oct 30, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants