[HLRC] Add Start/Stop Watch Service APIs. #34317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
98 tasks
hub-cap
approved these changes
Oct 15, 2018
Contributor
hub-cap
left a comment
hub-cap
left a comment
There was a problem hiding this comment.
Easy review to do. Thanks muchos. Please just update the docs and consider (nit) taking out those constructors. Im going to approve this, assuming you will be DRY'ing the docs pages and running the docs build locally as well. Ping me if you want a re-review.
|
|
||
| public class StartWatchServiceRequest implements Validatable { | ||
|
|
||
| public StartWatchServiceRequest() { |
Contributor
There was a problem hiding this comment.
Do we need default constructors here?
|
|
||
| public class StopWatchServiceRequest implements Validatable { | ||
|
|
||
| public StopWatchServiceRequest() { |
| @@ -0,0 +1,53 @@ | |||
| [[java-rest-high-watcher-start-watch-service]] | |||
Contributor
There was a problem hiding this comment.
These have a new tidier format. See #34203 for a much more concise version of the docs. Pls do this for both of the asciidoc pages you have added
Contributor
Author
|
@hub-cap Thanks for the review! Will commit once CI passes. |
jdconrad
added a commit
that referenced
this pull request
Oct 19, 2018
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds both the start water service and stop watcher service apis to the HLRC. Includes new request objects, tests, and documentation.