Skip to content

Conversation

@albendz
Copy link
Contributor

@albendz albendz commented Oct 3, 2018

In addition to #33452 for compatibility in 6.x branch before releasing breaking changes to 7.0.

  • unit tests updated
  • Logs in deprecation logger when combine or reduce is not provided
  • Behavior:
  • no combine, no reduce -> log both missing
  • combine, no reduce -> log reduce missing
  • no combine, reduce -> log combine missing
  • combine, reduce -> no additional logs

@colings86
Copy link
Contributor

@elasticmachine test this please

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albendz This LGTM, thanks for creating this extra PR. I've kicked off a test run and assuming this run is successful will merge both this and #33452

@colings86 colings86 added the :Analytics/Aggregations Aggregations label Oct 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@colings86 colings86 merged commit 17e47c6 into elastic:6.x Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants