Scripting: Convert script fields to use script context #34164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the use of SearchScript for script fields and adds a new FieldScript.
rjernst
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra |
jdconrad
approved these changes
Sep 28, 2018
Contributor
jdconrad
left a comment
jdconrad
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this!
| `List` of values. | ||
|
|
||
| {ref}/mapping-source-field.html[`ctx['_source']`] (`Map`):: | ||
| {ref}/mapping-source-field.html[`params['_source']`] (`Map`):: |
Contributor
There was a problem hiding this comment.
Do you mind adding read-only to this, like how _score was? This shouldn't be modified as part of a script field. My mistake from the first iteration of these docs.
| Map<String, String> deprecations = new HashMap<>(); | ||
| deprecations.put( | ||
| "doc", | ||
| "Accessing variable [doc] via [params.doc] from within a terms-set-query-script " + |
Contributor
There was a problem hiding this comment.
Think this was a copy and paste issue -- should be field-script and not terms-set-query
Member
Author
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 21, 2018
* master: Use trial license in docs tests (elastic#34673) Scripting: Convert script fields to use script context (elastic#34164) TEST: Mute testDedupByPrimaryTerm ingest: processor stats (elastic#34202)
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
This commit removes the use of SearchScript for script fields and adds a new FieldScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the use of SearchScript for script fields and adds
a new FieldScript.