Logging: Drop remaining Settings log ctor #34149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops the last logging constructor that takes `Settings` because it is no longer needed. Watcher goes through a lot of effort to pass `Settings` to `Logger` constructors and dropping `Settings` from all of those calls allowed us to remove quite a bit of log-based ceremony from watcher.
nik9000
added
:Core/Infra/Logging
Collaborator
|
Pinging @elastic/es-core-infra |
cbuescher
approved these changes
Oct 2, 2018
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
I left two nits but nothing big, rest LGTM
| when(watch.trigger()).thenReturn(trigger); | ||
| when(watch.condition()).thenReturn(InternalAlwaysCondition.INSTANCE); | ||
| ExecutableNoneInput noneInput = new ExecutableNoneInput(logger); | ||
| ExecutableNoneInput noneInput = new ExecutableNoneInput(); |
| super(settings, configPath); | ||
| Logger logger = Loggers.getLogger(TimeWarpedWatcher.class, settings); | ||
| logger.info("using time warped watchers plugin"); | ||
| LogManager.getLogger(TimeWarpedWatcher.class).info("using time warped watchers plugin"); |
Member
There was a problem hiding this comment.
I don't know how often this class is created, but maybe it makes sense to store a reference to the logger for later use if this class is instantiated more often.
Member
Author
|
Thanks for reviewing @cbuescher! |
nik9000
added a commit
that referenced
this pull request
Oct 4, 2018
Drops the last logging constructor that takes `Settings` because it is no longer needed. Watcher goes through a lot of effort to pass `Settings` to `Logger` constructors and dropping `Settings` from all of those calls allowed us to remove quite a bit of log-based ceremony from watcher.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 4, 2018
* master: (25 commits) HLRC: ML Adding get datafeed stats API (elastic#34271) Small fixes to the HLRC watcher documentation. (elastic#34306) Tasks: Document that status is not semvered (elastic#34270) HLRC: ML Add preview datafeed api (elastic#34284) [CI] Fix bogus ScheduleWithFixedDelayTests.testRunnableRunsAtMostOnceAfterCancellation Fix error in documentation for activete watch SCRIPTING: Terms set query expression (elastic#33856) Logging: Drop remaining Settings log ctor (elastic#34149) [ML] Remove unused last_data_time member from Job (elastic#34262) Docs: Allow skipping response assertions (elastic#34240) HLRC: Add activate watch action (elastic#33988) [Security] Multi Index Expression alias wildcard exclusion (elastic#34144) [ML] Label anomalies with multi_bucket_impact (elastic#34233) Document smtp.ssl.trust configuration option (elastic#34275) Support PKCS#11 tokens as keystores and truststores (elastic#34063) Fix sporadic failure in NestedObjectMapperTests [Authz] Allow update settings action for system user (elastic#34030) Replace version with reader cache key in IndicesRequestCache (elastic#34189) [TESTS] Set SO_LINGER and SO_REUSEADDR on the mock socket (elastic#34211) Security: upgrade unboundid ldapsdk to 4.0.8 (elastic#34247) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 4, 2018
* rename-ccr-stats: (25 commits) HLRC: ML Adding get datafeed stats API (elastic#34271) Small fixes to the HLRC watcher documentation. (elastic#34306) Tasks: Document that status is not semvered (elastic#34270) HLRC: ML Add preview datafeed api (elastic#34284) [CI] Fix bogus ScheduleWithFixedDelayTests.testRunnableRunsAtMostOnceAfterCancellation Fix error in documentation for activete watch SCRIPTING: Terms set query expression (elastic#33856) Logging: Drop remaining Settings log ctor (elastic#34149) [ML] Remove unused last_data_time member from Job (elastic#34262) Docs: Allow skipping response assertions (elastic#34240) HLRC: Add activate watch action (elastic#33988) [Security] Multi Index Expression alias wildcard exclusion (elastic#34144) [ML] Label anomalies with multi_bucket_impact (elastic#34233) Document smtp.ssl.trust configuration option (elastic#34275) Support PKCS#11 tokens as keystores and truststores (elastic#34063) Fix sporadic failure in NestedObjectMapperTests [Authz] Allow update settings action for system user (elastic#34030) Replace version with reader cache key in IndicesRequestCache (elastic#34189) [TESTS] Set SO_LINGER and SO_REUSEADDR on the mock socket (elastic#34211) Security: upgrade unboundid ldapsdk to 4.0.8 (elastic#34247) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Drops the last logging constructor that takes `Settings` because it is no longer needed. Watcher goes through a lot of effort to pass `Settings` to `Logger` constructors and dropping `Settings` from all of those calls allowed us to remove quite a bit of log-based ceremony from watcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the last logging constructor that takes
Settingsbecause it isno longer needed.
Watcher goes through a lot of effort to pass
SettingstoLoggerconstructors and dropping
Settingsfrom all of those calls allowed usto remove quite a bit of log-based ceremony from watcher.