Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 25, 2018

We should not access InternalEngine in other classes.

We should not access InternalEngine in other classes.
@dnhatn dnhatn added >non-issue v7.0.0 :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v6.5.0 labels Sep 25, 2018
@dnhatn dnhatn requested review from bleskes and s1monw September 25, 2018 03:14
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dnhatn
Copy link
Member Author

dnhatn commented Sep 25, 2018

Thanks @bleskes and @s1monw.

@dnhatn dnhatn merged commit 8a56369 into elastic:master Sep 25, 2018
@dnhatn dnhatn deleted the mv-const-engine branch September 25, 2018 23:20
dnhatn added a commit that referenced this pull request Sep 25, 2018
We should not access InternalEngine in other classes.
kcm pushed a commit that referenced this pull request Oct 30, 2018
We should not access InternalEngine in other classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >non-issue v6.5.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants