Retry fetching follower global checkpoint when it fails. #34019
Conversation
martijnvg
added
review
:Distributed Indexing/CCR
|
Pinging @elastic/es-distributed |
| } | ||
|
|
||
| private static boolean shouldRetry(Exception e) { | ||
| static boolean shouldRetry(Exception e) { |
There was a problem hiding this comment.
Maybe fetchGlobalCheckpoint() should be done in ShardFollowNodeTask like we update mapping or fetch document from shard changes api then we don't need to make to method package protected and complete reuse the retry logic that exists in ShardFollowNodeTask?
There was a problem hiding this comment.
On the fence on this one. I understand your reasons but I feel that ShardFollowNodeTask is complicated enough so we shouldn't move things in there unless strictly needed. As far as I can tell, the amount of code stays the same.
There was a problem hiding this comment.
I see, I'm still undecided. Lets leave it this way.
|
run the java11 tests |
|
@elasticmachine run gradle build tests |
2 similar comments
|
@elasticmachine run gradle build tests |
|
@elasticmachine run gradle build tests |
bleskes
left a comment
bleskes
left a comment
There was a problem hiding this comment.
Production code LGTM. Is there any way we can test this?
| } | ||
|
|
||
| private static boolean shouldRetry(Exception e) { | ||
| static boolean shouldRetry(Exception e) { |
There was a problem hiding this comment.
On the fence on this one. I understand your reasons but I feel that ShardFollowNodeTask is complicated enough so we shouldn't move things in there unless strictly needed. As far as I can tell, the amount of code stays the same.
I think when |
* master: Use more precise does S3 bucket exist method (elastic#34123) LLREST: Introduce a strict mode (elastic#33708) [CCR] Adjust list retryable errors (elastic#33985) Fix AggregationFactories.Builder equality and hash regarding order (elastic#34005) MINOR: Remove some deadcode in NodeEnv and Related (elastic#34133) Rest-Api-Spec: Correct spelling in filter_path description (elastic#33154) Core: Don't rely on java time for epoch seconds formatting (elastic#34086) Retry errors when fetching follower global checkpoint. (elastic#34019) Watcher: Reenable watcher stats REST tests (elastic#34107) Remove special-casing of Synonym filters in AnalysisRegistry (elastic#34034) Rename CCR APIs (elastic#34027) Fixed CCR stats api serialization issues and (elastic#33983) Support 'string'-style queries on metadata fields when reasonable. (elastic#34089) Logging: Drop Settings from security logger get calls (elastic#33940) SQL: Internal refactoring of operators as functions (elastic#34097)
4 participants
Closes #34016