Skip to content

Conversation

@davidkyle
Copy link
Member

Ignore unknown fields when parsing the job and datafeed persistent task parameters.

This is required for migrating the ml configuration work #32905 where additional fields will be added to the task parameters (as the config won't be available in the cluster state) and those fields need to be safely parsed during a rolling upgrade to 7.0

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member Author

retest this please

@davidkyle davidkyle force-pushed the lenient-parsing-ptask-params branch from 053cf4e to bbf8c2f Compare September 24, 2018 15:41
@davidkyle davidkyle merged commit 7bc7624 into elastic:master Sep 25, 2018
@davidkyle davidkyle deleted the lenient-parsing-ptask-params branch September 25, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants