refactor CompositeValuesSourceParserHelper for reusage #33945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
review
:Analytics/Aggregations
Collaborator
|
Pinging @elastic/es-search-aggs |
jimczi
approved these changes
Sep 21, 2018
Author
|
retest this please |
…ublic and moving toXContent
hendrikmuhs
force-pushed
the
CompositeValuesSourceBuilder-reusage
branch
from
c3da85f to
36ec735
Compare
hendrikmuhs
pushed a commit
that referenced
this pull request
Sep 25, 2018
…ublic (#33945) refactor CompositeValuesSourceParserHelper for reusage by making it public and moving toXContent into it
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
…ublic (#33945) refactor CompositeValuesSourceParserHelper for reusage by making it public and moving toXContent into it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor CompositeValuesSourceParserHelper for reusage by making it public and moving toXContent in order to be able to reuse the functionality downstream