SQL: Fix ANTL4 Grammar ambiguities. #33854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed rules in the grammar that were superfluous, as they are already "caught" other rules in the same context. Fixes: elastic#31885
Collaborator
|
Pinging @elastic/es-search-aggs |
matriv
pushed a commit
that referenced
this pull request
Sep 20, 2018
Removed rules in the grammar that were superfluous, as they are already "caught" other rules in the same context. Also switched to exact ambig detection for debug mode Fixes: #31885
Contributor
Author
|
Backported to |
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Sep 26, 2018
The `-` and `+` as a number literal prefix are already parsed by the rule in `valueExpression`. Follows: elastic#33854
matriv
pushed a commit
that referenced
this pull request
Oct 2, 2018
The `-` and `+` as a number literal prefix are already parsed by the rule in `valueExpression`. To accommodate this, there are some code changes that enables the `ExpressionBuilder` to parse Literal integers and decimals together with the `-/+` prefix sign (if exists) and validate them (wrong format, large numbers, etc.). Follows: #33854
matriv
pushed a commit
that referenced
this pull request
Oct 2, 2018
The `-` and `+` as a number literal prefix are already parsed by the rule in `valueExpression`. To accommodate this, there are some code changes that enables the `ExpressionBuilder` to parse Literal integers and decimals together with the `-/+` prefix sign (if exists) and validate them (wrong format, large numbers, etc.). Follows: #33854
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Removed rules in the grammar that were superfluous, as they are already "caught" other rules in the same context. Also switched to exact ambig detection for debug mode Fixes: #31885
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
The `-` and `+` as a number literal prefix are already parsed by the rule in `valueExpression`. To accommodate this, there are some code changes that enables the `ExpressionBuilder` to parse Literal integers and decimals together with the `-/+` prefix sign (if exists) and validate them (wrong format, large numbers, etc.). Follows: #33854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed rules in the grammar that were superfluous, as they
are already "caught" other rules in the same context.
Fixes: #31885