Remove superfluous semicolon from imports #33676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Maybe there is a checkstyle rule that we can apply for this or another precommit check that we could add, especially since it gives your IDE trouble? Would you investigate that? |
In the case where the double semicolon is in the middle of the import block, this cause my local Eclipse IDE to complain with an error, but its also nice to just clean this up in other places that at quick grep uncovered.
cbuescher
force-pushed
the
double-semicolon-fix
branch
from
de8f652 to
6d38c8f
Compare
Member
Author
|
@jasontedor fyi I opened #33682 separately against master since it required some reformatting of existing code and this change here is only necessary on 6.x. Can backport the other one if desired as well to 6.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the double semicolon is in the middle of the import block,
this cause my local Eclipse IDE to complain with an error, but its also nice to
just clean this up in other places that at quick grep uncovered.
No need for review, just opening to get a complete CI run.