Use file-based discovery not MockUncasedHostsProvider (backport of #33554) #33658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we use a special unicast hosts provider, the `MockUncasedHostsProvider`, in many integration tests, to deal with the dynamic nature of the allocation of ports to nodes. However elastic#33241 allows us to use file-based discovery to achieve the same goal, so the special test-only `MockUncasedHostsProvider` is no longer required. This change removes `MockUncasedHostProvider` and replaces it with file-based discovery in tests based on `EsIntegTestCase`.
DaveCTurner
added
>non-issue
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
This was referenced Sep 13, 2018
DaveCTurner
deleted the
2018-09-13-6.x-file-based-discovery-in-tests
branch
Contributor
Author
|
Merged to 6.x now that it's passing CI. See #33554 for review comments etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use a special unicast hosts provider, the
MockUncasedHostsProvider,in many integration tests, to deal with the dynamic nature of the allocation of
ports to nodes. However #33241 allows us to use file-based discovery to achieve
the same goal, so the special test-only
MockUncasedHostsProvideris no longerrequired.
This change removes
MockUncasedHostProviderand replaces it with file-baseddiscovery in tests based on
EsIntegTestCase.This is simply a backport of #33554 to 6.x, opened as a separate PR as 6.x is currently not passing CI.