Skip to content

Resync fails to notify on unavaiable exceptions #33615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2018
Merged

Resync fails to notify on unavaiable exceptions #33615

merged 1 commit into from
Sep 13, 2018

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 11, 2018 •
edited
Loading

We fail to notify the resync listener if the resync replication hits a
shard unavailable exception. Moreover, we no longer need to swallow
these unavailable exceptions.

Relates #31179
Closes #33613

@dnhatn
Resync fails to notify on unavaiable exceptions
c62ac7a 
We fail to notify the resync listener if the resync replication hits a
shard unavailable exception. Moreover, we no longer need to swallow
these unavailable exceptions.

Relates elastic#28571
Closes elastic#33613
@dnhatn dnhatn added >bug :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v7.0.0 v6.5.0 v6.4.1 labels Sep 11, 2018
@dnhatn dnhatn requested review from bleskes and ywelsch September 11, 2018 22:51
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 11, 2018

Pinging @elastic/es-distributed

@dnhatn dnhatn added the review label Sep 12, 2018
ywelsch
ywelsch approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this safe to do because this condition can only happen if the primary fails before or during a resync, and calling listener.onFailure will then result in a noop.

@dnhatn
Copy link
Member Author

dnhatn commented Sep 13, 2018

Thanks @ywelsch for reviewing.

@dnhatn dnhatn merged commit b097eff into elastic:master Sep 13, 2018
@dnhatn dnhatn deleted the resync-notify branch September 13, 2018 01:28
dnhatn added a commit that referenced this pull request Sep 13, 2018
@dnhatn
Resync fails to notify on unavaiable exceptions (#33615)
345899e 
We fail to notify the resync listener if the resync replication hits a
shard unavailable exception. Moreover, we no longer need to swallow
these unavailable exceptions.

Relates #28571
Closes #33613
dnhatn added a commit that referenced this pull request Sep 13, 2018
@dnhatn
Resync fails to notify on unavaiable exceptions (#33615)
6a69aae 
We fail to notify the resync listener if the resync replication hits a
shard unavailable exception. Moreover, we no longer need to swallow
these unavailable exceptions.

Relates #28571
Closes #33613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bleskes bleskes Awaiting requested review from bleskes

1 more reviewer

@ywelsch ywelsch ywelsch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>bug :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v6.4.1 v6.5.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnhatn @elasticmachine @ywelsch @colings86