Deprecates the standard filter #33468
Conversation
This change deprecates the noop standard filter. It is already removed in 7 but the deprecation was missing.
jimczi
added
:Search Relevance/Analysis
|
Pinging @elastic/es-search-aggs |
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Change itself looks great, I found several mentions of the standard tokenizer in the docs though that might need to be changed or adapted to account for the warnings that are added here. e.g. I think "reference/analysis/tokenfilters/standard-tokenfilter.asciidoc" could get a note saying this is deprecated in removed already in 7.0. I'll grep a little bit to see if I can find other occurances.
| .put("soranistem", MovedToAnalysisCommon.class) | ||
| .put("spanishlightstem", MovedToAnalysisCommon.class) | ||
| .put("standard", StandardTokenFilterFactory.class) | ||
| .put("standard", Void.class) |
There was a problem hiding this comment.
nit: according to the classes comment there is a Deprecated.class that could be used here. Doesn't change anything in the end I guess.
|
These are some other docs files that I think might contain references to the standard filter. I think they can stay as they are, but probably it also wouldn't hurt removing the filter since it does nothing:
|
…tion note in the docs
|
Thanks @cbuescher |
3 participants
This change deprecates the noop standard filter. It is already removed in 7 but
the deprecation was missing.