Docs: Add password keystore setting for email account passwords #33409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Sep 5, 2018
|
|
||
| In order to not store the account SMTP password as plaintext in the | ||
| elasticsearch yaml file, you should use the keystore instead (you can still | ||
| store the password in the elasticsearch configuration file, if you need to) |
Member
There was a problem hiding this comment.
I don't think we should have this node about putting the password in elasticsearch.yml. This should be going away; we shouldn't be promoting it.
Contributor
Author
There was a problem hiding this comment.
removed that mention
| -------------------------------------------------- | ||
|
|
||
| In order to not store the account SMTP password as plaintext in the | ||
| elasticsearch yaml file, you should use the keystore instead (you can still |
Member
There was a problem hiding this comment.
We should crosslink to the keystore docs ("secure settings").
spinscale
added a commit
that referenced
this pull request
Dec 6, 2018
Always refer to secure settings when setting up email account passwords
spinscale
added a commit
that referenced
this pull request
Dec 6, 2018
Always refer to secure settings when setting up email account passwords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keystore configuration options have not been mentioned yet, but have so in hipchat/jira/pagerduty actions.