SQL: Improve alias vs index resolution #33393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve pattern resolution for aliases vs indices
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
reviewed
Sep 4, 2018
| SHOW TABLES "test*,-test_emp*"; | ||
|
|
||
| name:s | type:s | ||
| test_alias |ALIAS |
Member
There was a problem hiding this comment.
I see how this one should show aliases. Can you add a test that shouldn't show aliases so that it hits more of the change you made above?
Member
Author
There was a problem hiding this comment.
Unfortunately that doesn't currently work; I've raised a bug for it: #33395
costin
added a commit
that referenced
this pull request
Sep 10, 2018
Improve pattern resolution for aliases vs indices (cherry picked from commit 7b923ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #33363 which improves pattern resolution for aliases vs indices.