-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adds usage data for ILM #33377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds usage data for ILM #33377
Conversation
|
Pinging @elastic/es-core-infra |
|
@elasticmachine test this please |
1 similar comment
|
@elasticmachine test this please |
|
Do we know how people are expected to use this data? I believe it does a great job providing all the policy usage info on a per-policy basis for users to group and keep track of things. What I am not clear on is, who is expected to consume this data? is it other Elasticsearch toolings, or users? @eskibars, since Colin is out, I would love your input on this since I am missing some context. thanks! |
|
After speaking with @eskibars in a different channel, I learned that these documents are intended to be aggregated as documents in ES, and so their structure should reflect that intention. If that is the case, should the phase be contained in a field value that can be used in term aggregations? |
talevy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after is now minimum_age
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to store this in milliseconds so that we can do statistics on it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at first I thought this format would make it difficult to know how many policies didn't use a certain field, but after a few test queries, it looks like this is sufficient
|
@talevy I addressed your comment, could you take another look? |
talevy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will be good!
should we add yaml tests?
* Adds usage data for ILM * Adds tests for IndexLifecycleFeatureSetUsage and friends * Adds tests for IndexLifecycleFeatureSet * Fixes merge errors * Add number of indices managed to usage stats Also adds more tests * Addresses Review comments
Currently the response from the x-pack usage API would be: