Add NoOps to Lucene for failed delete operations #33217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we add a NoOp to Lucene and translog if we fail to process an indexing operation. However, we are only adding NoOps to translog for delete operations. In order to have a complete history in Lucene, we should add a Noop to both Lucene and translog if we fail to apply a delete.
dnhatn
added
>feature
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
@elasticmachine test this please. |
Contributor
|
technically I agree with this. But what is the scenario where a delete op fails? I don't necessarily understand how this can happen. Can you explain this a bit? |
Member
Author
|
@s1monw To be honest, I am not sure if this ever happens. I made this change because:
|
Contributor
|
I suggest we make this change for correctness and then open an issue to revisit this altogether. I think it's unnecessary we can't recover from any issue during a delete IMO |
Member
Author
s1monw
approved these changes
Aug 30, 2018
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
LGTM given that we have a followup
Member
Author
|
Thanks @s1monw. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Aug 30, 2018
Today we add a NoOp to Lucene and translog if we fail to process an indexing operation. However, we are only adding NoOps to translog for delete operations. In order to have a complete history in Lucene, we should add NoOps of failed delete operations to both Lucene and translog. Relates elastic#29530
dnhatn
added a commit
that referenced
this pull request
Aug 30, 2018
Today we add a NoOp to Lucene and translog if we fail to process an indexing operation. However, we are only adding NoOps to translog for delete operations. In order to have a complete history in Lucene, we should add NoOps of failed delete operations to both Lucene and translog. Relates #29530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we add a NoOp to Lucene and translog if we fail to process an
indexing operation. However, we are only adding NoOps to translog for
delete operations. In order to have a complete history in Lucene, we
should add NoOps of failed delete operations to both Lucene and translog.
Relates #29530