Make soft-deletes settings final #33172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we do not support changing the soft-deletes setting even with closed indices. Therefore we should it a final setting.
dnhatn
added
>feature
:Distributed Indexing/CCR
Collaborator
|
Pinging @elastic/es-distributed |
Member
|
@dnhatn Should we mark this setting as |
Member
|
Actually, looking more closely, |
s1monw
approved these changes
Aug 27, 2018
Member
Author
|
Thanks @jasontedor and @s1monw for reviewing! |
jasontedor
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 28, 2018
* ccr: Fix ShardFollowNodeTask.Status equals and hash code (elastic#33189) Make soft-deletes settings final (elastic#33172) Only fetch mapping updates when necessary (elastic#33182)
dnhatn
added a commit
that referenced
this pull request
Aug 28, 2018
For now, we do not support changing the soft-deletes setting even with closed indices. Therefore we should make it a final setting. Relates #29530
|
i want to know, why can not open soft_delete setting dynamicly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we do not support changing the soft-deletes setting even with
closed indices. Therefore we should make it a final setting.