Ensure that _exists queries on keyword fields use norms when they're available. #33006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>bug
WIP
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search-aggs |
jtibshirani
force-pushed
the
exists-queries-on-keywords
branch
from
a15b142 to
2be290d
Compare
jimczi
reviewed
Aug 21, 2018
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Looks good, thanks @jtibshirani
Should we also disable the creation of the field names field if norms are activated:
jtibshirani
force-pushed
the
exists-queries-on-keywords
branch
from
ef4cc72 to
5b9e478
Compare
jtibshirani
force-pushed
the
exists-queries-on-keywords
branch
from
5b9e478 to
b03e5ea
Compare
jimczi
approved these changes
Aug 21, 2018
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Left a minor comment, LGTM otherwise.
| Field field = new Field(fieldType().name(), binaryValue, fieldType()); | ||
| fields.add(field); | ||
|
|
||
| if (!fieldType().hasDocValues() && fieldType().omitNorms()) { |
Contributor
There was a problem hiding this comment.
nit: we prefer to use fieldType().hasDocValues() == false for clarity.
Contributor
Author
There was a problem hiding this comment.
Got it. I will struggle a bit with this inside but codebase consistency is most important :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.