-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Add RequestedAuthnContext Documentation #32946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docs for elastic#31238 - Adds documentation for the req_authn_context_class_ref setting - Adds a section in SAML Guide regarding the use of SAML Authentication Context.
|
Pinging @elastic/es-security |
tvernum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions, but @lcawl will probably offer something better.
| in the Authentication Request. The IdP attempts to grant these restrictions, | ||
| and either returns an indication of which it satisfied in the Authentication | ||
| Statement of the SAML Response if it can, or it fails to authenticate the | ||
| user if it can't adhere to the restrictions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will read better if it's more of a "if-scenario-A, then action-B ..." rather than "Either action-B if scenario-A, or ..."
For example
attempts to grant these restrictions,
and if it cannot adhere to the restrictions, then it fails the authentication attempt.
If the user is successfully authenticated, then the Authentication Statement of the
SAML Response will return an indication of the restrictions that were satisfied.
| the Authentication Context Class Reference that is part of the | ||
| Authentication Statement of the SAML Assertion is examined. If it matches | ||
| one of the requested values, the authentication is considered successful, | ||
| otherwise failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
otherwise, the authentication attempt fails.
?
| A comma separated list of Authentication Context Class Reference values to be | ||
| included in the Requested Authentication Context when requesting the IdP to | ||
| authenticate the current user. The Authentication Context of the corresponding | ||
| authentication response should contain at least one of the requested values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need a link to the more complete explanation?
It doesn't make sense on its own unless you're a hard-core SAML expert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a link
lcawl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some edits, now it LGTM
Add documentation for #31238 - Add documentation for the req_authn_context_class_ref setting - Add a section in SAML Guide regarding the use of SAML Authentication Context.
Add documentation for #31238 - Add documentation for the req_authn_context_class_ref setting - Add a section in SAML Guide regarding the use of SAML Authentication Context.
Docs for #31238
Authentication Context.