Handle 6.4.0+ BWC for Application Privileges #32929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the application privileges feature was backported to 6.x/6.4 the BWC version checks on the backport were updated to 6.4.0, but master was not updated. This commit updates all relevant version checks, and adds tests.
tvernum
added
>bug
review
v7.0.0
:Security/Security
Collaborator
|
Pinging @elastic/es-security |
tvernum
commented
Aug 17, 2018
| final HasPrivilegesResponse copy = serializeAndDeserialize(original, version); | ||
|
|
||
| assertThat(copy.isCompleteMatch(), equalTo(original.isCompleteMatch())); | ||
| // assertThat(copy.getClusterPrivileges(), equalTo(original.getClusterPrivileges())); |
Contributor
Author
There was a problem hiding this comment.
There is a separate bug that this field is never serialized.
I'll raise another PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application privileges feature was backported to 6.x/6.4 the
BWC version checks on the backport were updated to 6.4.0, but master
was not updated.
This commit updates all relevant version checks, and adds tests.