Fix north pole overflow error in GeoHashUtils.bbox() #32891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an overflow error in GeoHashUtils.bbox() calculation of a bounding box for geohashes with maximum precision located next to the north pole. Closes elastic#32857
imotov
added
>bug
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
|
I wonder, if in case of overflow, we should set manually the final topRight latitude to 90 degrees, which somewhat is what it means. |
imotov
added a commit
that referenced
this pull request
Aug 21, 2018
Fixes an overflow error in GeoHashUtils.bbox() calculation of a bounding box for geohashes with maximum precision located next to the north pole.
imotov
added a commit
that referenced
this pull request
Aug 21, 2018
Fixes an overflow error in GeoHashUtils.bbox() calculation of a bounding box for geohashes with maximum precision located next to the north pole.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an overflow error in GeoHashUtils.bbox() calculation of a
bounding box for geohashes with maximum precision located next to the
north pole.
Closes #32857