Millisecond output optional in _cat/indices test #32547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we assert that _cat/indices returns a string matching
\d\d\d\d\-\d\d\-\d\dT\d\d:\d\d:\d\d.\d\d\d?Z
in the `creation.date.string` field. However, if the index was created exactly
on the second then the milliseconds part is omitted from the output. This updates
the test to allow for this case, and also to insist that the separator between the
seconds and the milliseconds fields is `.` and not an arbitrary character.
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
Bah, already fixed by #32510. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we assert that _cat/indices returns a string matching
in the
creation.date.stringfield. However, if the index was created exactlyon the second then the milliseconds part is omitted from the output. This updates
the test to allow for this case, and also to insist that the separator between the
seconds and the milliseconds fields is
.and not an arbitrary character.