-
Notifications
You must be signed in to change notification settings - Fork 25.6k
change default indices.lifecycle.poll_interval to something sane #32521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-core-infra |
|
I take it this is the issue to kick off the discussion on what the interval should be? For what it's worth, I vote 5 minutes :) |
|
@dakrone yup! let the voting begin! because I sure do not have a clue what the "right" interval is. Anywhere between 5min and 15min sounds reasonable to me. The 15min that was seeded in the PR was from one of my conversations with @colings86. |
|
@dakrone could you explain why you think 5 minutes is a good value here? The poll interval is used for 2 purposes: 1) as a fallback to make sure we make progress in the event of a cluster change not happening or a client async listener not firing, 2) to trigger a check on the rollover conditions since an index breaking through these conditions does not cause a cluster state change Reasons I think 15 minutes is a good value:
|
|
@colings86 it's purely a gut feeling based on what I think a "medium but not long period of time" is. It's like the definition of "a few", to me, "a few" to me is 3 to 8, and I'd like ILM to check every few minutes, so that led to the 5 minute interval. This also includes a big caveat that I'll be completely happy if we go with 15 minutes, just wanted to explain my reasoning :) |
|
Since many of these arguments feel like they could work with a variety of other minute values. I will play in the middle, two minutes above few, and an average of both suggestions... 10minutes? |
|
@dakrone thanks for explaining your reasoning. Personally I would be comfortable with anything from 5 minutes to 15 minutes. I think anything shorter than 5 minutes would be too often and anything long than 15 minutes might not be responsive enough for rollover. So I'm happy for the 10 minutes that @talevy proposed 😄 |
|
10 minutes it is! |
18d8cf4 to
d3a5e89
Compare
This was originally set to a few seconds while prototyping things. This interval is for the scheduled trigger of policies. Policies have this extra trigger beyond just on cluster-state changes because cluster-state changes may not be happeneing in a cluster for whatever reason, and we need to continue making progress. Updating this value to be larger is reasonable since not all operations are expected to be completed in the span of seconds, but instead in minutes and hours. 10 minutes is sane.
d3a5e89 to
22e2bb7
Compare
dakrone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
thanks @dakrone! |
) This was originally set to a few seconds while prototyping things. This interval is for the scheduled trigger of policies. Policies have this extra trigger beyond just on cluster-state changes because cluster-state changes may not be happeneing in a cluster for whatever reason, and we need to continue making progress. Updating this value to be larger is reasonable since not all operations are expected to be completed in the span of seconds, but instead in minutes and hours. 10 minutes is sane.
This was originally set to a few seconds while prototyping things.
This interval is for the scheduled trigger of policies. Policies
have this extra trigger beyond just on cluster-state changes because
cluster-state changes may not be happeneing in a cluster for
whatever reason, and we need to continue making progress. Updating
this value to be larger is reasonable since not all operations
are expected to be completed in the span of seconds, but instead in
minutes and hours.