Skip to content

Conversation

@tvernum
Copy link
Contributor

@tvernum tvernum commented Jul 26, 2018

The previous name incorrectly implies that the realms are actively
authorizing something, however the reality is that they are realms
that are consulted for the purposes of authorization.

The previous name incorrectly implies that the realms are actively
authorizing something, however the reality is that they are realms
that are consulted for the purposes of authorization.
@tvernum tvernum added review :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels Jul 26, 2018
@tvernum tvernum requested review from bizybot and jaymode July 26, 2018 08:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum tvernum merged commit d9e5bb9 into elastic:security-lookup-realms Jul 31, 2018
@tvernum tvernum removed the review label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants