Remove "best_compression" option from the ForceMergeAction #32373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is only settable while the index is closed, and doesn't make sense for a force merge. Relates to elastic#29823
dakrone
added
the
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
This option is only settable while the index is closed, and doesn't make sense for a force merge. Relates to #29823
|
I was wondering if it’s removed from force merge step, in which step do I specify best_compression during the whole lifecycle? |
Contributor
|
Hi @wandermyz, There isn't a place in ILM that allows one to specify Since closing this issue, we've improved both the infrastructure and experience of ILM actions, so I think that Elasticsearch may be open to re-introducing this in the future. |
Contributor
|
We already have an issue open to add this back to ILM: #41274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is only settable while the index is closed, and doesn't make sense
for a force merge.
Relates to #29823