Release pipelined request in netty server tests #32368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Netty4HttpServerPipeliningTests adds a different request handler to the netty pipeline. This request does not properly release pipelined request. This means that when we enable leak detection, the test fails. This commit properly releases the request.
Tim-Brooks
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
I'm not clear if this is supposed to go to v6.5 or v6.4? There is no need to go to 6.4 as it is not fixing an actual issue (opposed to fixes tests in face of leak detection). But maybe I see some discussions that it is blocking something? |
original-brownbear
approved these changes
Jul 25, 2018
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM (if it goes green) :)
dnhatn
added a commit
that referenced
this pull request
Jul 27, 2018
* 6.x: Only enforce password hashing check if FIPS enabled (#32383) Introduce fips_mode setting and associated checks (#32326) [DOCS] Fix formatting error in Slack action Ingest: Support integer and long hex values in convert (#32213) Release pipelined request in netty server tests (#32368) Add opaque_id to index audit logging (#32260) Painless: Fix documentation links to use existing refs (#32335) Painless: Decouple PainlessLookupBuilder and Whitelists (#32346) [DOCS] Adds recommendation for xpack.security.enabled (#32345) [test] package pre-install java check (#32259) [DOCS] Adds link from bucket_span property to common time units [DOCS] Fixes typo in ML aggregations page [ML][DOCS] Add documentation for detector rules and filters (#32013) Bump the 6.x branch to 6.5.0 (#32361) fixes broken build repository-s3 for third-party-tests
jasontedor
pushed a commit
that referenced
this pull request
Aug 30, 2018
The Netty4HttpServerPipeliningTests adds a different request handler to the netty pipeline. This request does not properly release pipelined request. This means that when we enable leak detection, the test fails. This commit properly releases the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Netty4HttpServerPipeliningTests adds a different request handler to
the netty pipeline. This request does not properly release pipelined
request. This means that when we enable leak detection, the test fails.
This commit properly releases the request.