CCR: Fix incorrect read request completion condition #32266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we consider a read request is exhausted if from_seqno is equal to or greater than the max_seqno. However, if we stop when from_seqno equals to the max_required_seqno, we will miss an operation whose seqno is max_required_seqno because that operation was not fetched yet. Our CI https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+ccr+feature-branch-periodic/997/console found that we missed an operation.
dnhatn
added
>bug
:Distributed Indexing/CCR
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
We missed an operation in this run |
dnhatn
changed the title
bleskes
approved these changes
Jul 22, 2018
| task.coordinateReads(); | ||
| ShardChangesAction.Response response = generateShardChangesResponse(0, 64, 1L, 64L); | ||
| task.handleReadResponse(0L, 64L, response); | ||
| ShardChangesAction.Response response = generateShardChangesResponse(0, 64, 1L, 63L); |
Contributor
There was a problem hiding this comment.
I wonder if using fromSeq and toSeqNo (instead of size) will result in this being less confusing.
Member
Author
|
Thanks @bleskes for reviewing. |
dnhatn
added a commit
that referenced
this pull request
Jul 23, 2018
Today we consider a read request is exhausted if from_seqno is equal to or greater than the max_required_seqno. However, if we stop when from_seqno equals to the max_required_seqno, we will miss an operation whose seqno is max_required_seqno because we have not seen that operation yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we consider a read request is exhausted if
from_seqnois equal to or greater than themax_required_seqno. However, if we stop whenfrom_seqnoequals to themax_required_seqno, we will miss an operation whose seqno ismax_required_seqnobecause that operation was not seen yet.