Remove support for deprecated StoredScript contexts #31394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
add to whitelist |
nik9000
added
:Core/Infra/Scripting
Collaborator
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Jun 19, 2018
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
This looks good. I have one comment.
Member
There was a problem hiding this comment.
TEMPLATE_NO_WRAPPER_PARSE_FIELD and TEMPLATE_PARSE_FIELD constants can be removed now right?
Contributor
Author
There was a problem hiding this comment.
Yes, I already did this. I will commit this together with the fix for the failing test. The method parseRemaining can also go away.
sohaibiftikhar
force-pushed
the
stored_script
branch
from
694c2fc to
b359b1e
Compare
Contributor
Author
nik9000
reviewed
Jun 25, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add something to migrate_7_0/api.asciidoc to document that this deprecated format is now unsupported?
sohaibiftikhar
force-pushed
the
stored_script
branch
from
18c7586 to
262c7d9
Compare
dnhatn
added a commit
that referenced
this pull request
Jul 5, 2018
* master: REST high-level client: add get index API (#31703) SQL: Allow long literals (#31777) SQL: Fix incorrect message for aliases (#31792) Test: Do not remove xpack templates when cleaning (#31642) Reduce more raw types warnings (#31780) Add unreleased version 6.3.2 Scripting: Remove support for deprecated StoredScript contexts (#31394) [ML][TEST] Use java 11 valid time format in DataDescriptionTests (#31817) [ML] Don't treat stale FAILED jobs as OPENING in job allocation (#31800) [ML] Fix calendar and filter updates from non-master nodes (#31804) Fix license header generation on Windows (#31790) mark RollupIT.testTwoJobsStartStopDeleteOne as AwaitsFix mark SearchAsyncActionTests.testFanOutAndCollect as AwaitsFix Correct exclusion of test on JDK 11 Fix doclint jdk 11 Add JDK11 support and enable in CI (#31644) Watcher: Fix check for currently executed watches (#31137) Watcher: Ensure correct method is used to read secure settings (#31753) SQL: Update CLI logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- related to #27612
-- follows up on #28939